Issue 3556: Search for 'dances with video'
- Object
- Braes of Atholl (Dance)
- Submitter
- Mair A-W (mairaw)
- Assigned to
- Anselm Lingnau
- Priority
- Normal
- Disposition
- Being handled
- Description
-
Issue was raised in January that video is private and should perhaps be removed – appears to have been resolved by removing video. However a search (e.g. for the formation Reel of three – diagonal) specifying ‘dances with videos’ still returns this dance…
Previous Actions
- Date June 5, 2024, 12:41 a.m.
- User Mair A-W (mairaw)
New issue submitted
- Date June 5, 2024, 1:20 a.m.
- User Anselm Lingnau (anselm)
Assigned changed to “anselm” (previously “None”)
Disposition changed to “Being handled” (previously “New”)
That’s a bug in the SCDDB code. What we do in cases like this is that we don’t actually remove the video from the database, we just block it so it isn’t accidentally re-added later. However as far as the complex-dance-search function is concerned, any videos (including blocked ones) count towards a dance having videos. (I don’t remember the exact chronology but it is probable that the “dances with videos” search function came first and the idea of “blocking” videos that we have found unsuitable for the database came later, and it didn’t occur to me that from the POV of the search function, a blocked video is still a video, even if it is never displayed to users.)
I’ll change the dance search code such that blocked videos are no longer considered when trying to find “dances with videos”. Good catch.